f89d735 - Better method to avoid unnecessary CD updates

[wowui.git] / OmaUF / CastBar.lua

diff --git a/OmaUF/CastBar.lua b/OmaUF/CastBar.lua
index 7485a8a..61c107e 100644 (file)
--- a/OmaUF/CastBar.lua
+++ b/OmaUF/CastBar.lua
@@ -17,7 +17,7 @@ OmaUFCastBar = M;
 
 -- TODO trade skill bar updates as well, check Quartz modules/Tradeskill.lua
 local function onUpdate(bar)
-    if not bar:IsShown() then return end -- TODO little fadeout possibly
+    if not bar:IsShown() then return end
     local width = bar.icon:IsShown() and bar.cast.width or bar.cast.width; -- TODO fullwidth
     local startTime, endTime = bar.startTime, bar.endTime;
     local currentClamped = min(GetTime(), endTime);
@@ -53,14 +53,15 @@ local function startCast(bar, unit, channeling)
     local name, icon, startTime, endTime, noInterrupt, id;
     if channeling then
         name, _, _, icon, startTime, endTime, _, noInterrupt = UnitChannelInfo(unit);
+        if not startTime or not endTime then return nil end
         bar.channeling = true;
         bar.cast.color = channelingColor;
     else
         _, _, name, icon, startTime, endTime, _, _, noInterrupt, id = UnitCastingInfo(unit);
+        if not startTime or not endTime then return nil end
         bar.channeling = nil;
         bar.cast.color = castingColor;
     end
-    if not startTime or not endTime then return nil end
     bar.startTime = startTime / 1000;
     bar.endTime = endTime / 1000;
     -- don't show samwise for non-existent icons
@@ -97,6 +98,12 @@ local events = {
     ["UNIT_SPELLCAST_START"] = function(bar, unit)
         startCast(bar, unit);
     end,
+    ["PLAYER_TARGET_CHANGED"] = function(bar)
+        bar:Hide();
+        if not startCast(bar, bar.unit) then
+            startCast(bar, bar.unit, true);
+        end
+    end,
     ["UNIT_SPELLCAST_CHANNEL_START"] = function(bar, unit)
         startCast(bar, unit, true);
     end,
@@ -122,6 +129,8 @@ local function onEvent(bar, event, unit)
     if unit == bar.unit or (bar.unit == "player" and unit == "vehicle") then
         --print(unit, event)
         events[event](bar, unit);
+    elseif event == "PLAYER_TARGET_CHANGED" then
+        events[event](bar);
     end
 end
 
@@ -137,6 +146,7 @@ function M.RegisterCastEvents(bar)
     bar:RegisterEvent("UNIT_SPELLCAST_CHANNEL_UPDATE");
     bar:RegisterEvent("UNIT_SPELLCAST_INTERRUPTIBLE");
     bar:RegisterEvent("UNIT_SPELLCAST_NOT_INTERRUPTIBLE");
+    if bar.unit == "target" then bar:RegisterEvent("PLAYER_TARGET_CHANGED") end
     bar:SetScript("OnUpdate", onUpdate);
     -- trigger initial check
     if not startCast(bar, bar.unit) then