X-Git-Url: https://www.aleksib.fi/git/wowui.git/blobdiff_plain/578ca7c8f329a11e54a52b035f7ce0d8161dfb90..26c8dda69b63296b6c89a6a8485bb0d9996a22e4:/OmaAB/ActionBars.lua diff --git a/OmaAB/ActionBars.lua b/OmaAB/ActionBars.lua index 50a88b6..e6637e9 100644 --- a/OmaAB/ActionBars.lua +++ b/OmaAB/ActionBars.lua @@ -16,7 +16,8 @@ local CreateFrame = CreateFrame; local RegisterStateDriver = RegisterStateDriver; local CooldownFrame_Set, CooldownFrame_Clear = CooldownFrame_Set, CooldownFrame_Clear; local CTimerAfter = C_Timer.After; -local GameTooltip = nil; +local GameTooltip = GameTooltip; +local GameTooltip_SetDefaultAnchor = GameTooltip_SetDefaultAnchor; local COOLDOWN_TYPE_LOSS_OF_CONTROL = COOLDOWN_TYPE_LOSS_OF_CONTROL; local COOLDOWN_TYPE_NORMAL = COOLDOWN_TYPE_NORMAL; local CDTexture = "Interface\\Cooldown\\edge"; @@ -120,6 +121,7 @@ local chars = { ["Stormreaver"] = { ["Vildan"] = {1, 2, 3, 4,}, ["Gedren"] = {1, 2, 3, 4,}, + ["Gazden"] = {1, 2, 3, 4,}, }, }; @@ -130,6 +132,15 @@ local ActionBars = CreateFrame("Frame", "OmaActionBars", UIParent); local inheritedFrames = "SecureActionButtonTemplate,SecureHandlerDragTemplate,SecureHandlerStateTemplate"; +local function showTooltip(secure) + GameTooltip_SetDefaultAnchor(GameTooltip, secure); + GameTooltip:SetAction(secure:GetAttribute("action")); +end + +local function hideTooltip() + GameTooltip:Hide(); +end + local numChargeCDs = 0; local function createChargeCD(parent) numChargeCDs = numChargeCDs + 1; @@ -160,6 +171,18 @@ local function updateCooldown(button, slot) local locstart, locduration = GetActionLossOfControlCooldown(slot); local start, duration, enable, modrate = GetActionCooldown(slot); local charges, maxcharges, chargestart, chargeduration, chargemodrate = GetActionCharges(slot); + -- avoid as many updates as possible by checking if there's changes first + if button.prev and + button.prev[1] == locstart and button.prev[2] == locduration and + button.prev[3] == start and button.prev[4] == duration and + button.prev[5] == enable and button.prev[6] == modrate and + button.prev[7] == charges and button.prev[8] == maxcharges and + button.prev[9] == chargestart and button.prev[10] == chargeduration and + button.prev[11] == chargemodrate then + return; + end + button.prev = { locstart, locduration, start, duration, enable, modrate, + charges, maxcharges, chargestart, chargeduration, chargemodrate }; if (locstart + locduration) > (start + duration) then if button.cd.currentCooldownType ~= COOLDOWN_TYPE_LOSS_OF_CONTROL then button.cd:SetEdgeTexture(locCDTexture); @@ -232,22 +255,14 @@ local function updateState(button, slot) button:SetChecked(IsCurrentAction(slot) or IsAutoRepeatAction(slot)); end -local function updateGlow(button, slot, spell, hide) +local function updateGlow(button, slot) local stype, id, _ = GetActionInfo(slot); - if stype == "spell" and (spell and id == spell or IsSpellOverlayed(id)) then - if hide then - button.glow:Hide(); - else - button.glow:Show(); - end + if stype == "spell" and IsSpellOverlayed(id) then + button.glow:Show(); elseif stype == "macro" then local _, _, macroid = GetMacroSpell(id); - if macroid and (spell and macroid == spell or IsSpellOverlayed(macroid)) then - if hide then - button.glow:Hide(); - else - button.glow:Show(); - end + if macroid and IsSpellOverlayed(macroid) then + button.glow:Show(); else button.glow:Hide(); end @@ -256,6 +271,32 @@ local function updateGlow(button, slot, spell, hide) end end +local function startGlow(button, slot, spell) + local stype, id, _ = GetActionInfo(slot); + if stype == "spell" and id == spell then + button.glow:Show(); + elseif stype == "macro" then + local _, _, macroid = GetMacroSpell(id); + if macroid and macroid == spell then + button.glow:Show(); + end + end + -- TODO FlyoutHasSpell glow +end + +local function stopGlow(button, slot, spell) + local stype, id, _ = GetActionInfo(slot); + if stype == "spell" and id == spell then + button.glow:Hide(); + elseif stype == "macro" then + local _, _, macroid = GetMacroSpell(id); + if macroid and macroid == spell then + button.glow:Hide(); + end + end + -- TODO FlyoutHasSpell glow +end + local function updateButton(button, slot) if HasAction(slot) then activeButtons[slot] = button; @@ -434,6 +475,10 @@ local function createActionBar(parent, config) end if config.nomouse then secure:EnableMouse(false); + else + -- only show tooltips for bars with mouse interaction + secure:SetScript("OnEnter", showTooltip); + secure:SetScript("OnLeave", hideTooltip); end secure:SetWidth(config.size or 32); secure:SetHeight(config.size or 32); @@ -458,8 +503,8 @@ local function createActionBar(parent, config) secure.autocastable:Hide(); secure.glow = secure:CreateTexture(nil, "OVERLAY", nil, 1); secure.glow:SetPoint("CENTER"); - secure.glow:SetWidth(config.size and config.size+20 or 52); - secure.glow:SetHeight(config.size and config.size+20 or 52); + secure.glow:SetWidth(config.size and config.size+26 or 53); + secure.glow:SetHeight(config.size and config.size+26 or 53); secure.glow:SetTexture("Interface\\SpellActivationOverlay\\IconAlert"); secure.glow:SetTexCoord(0.00781250, 0.50781250, 0.27734375, 0.52634375); secure.glow:Hide(); @@ -517,23 +562,11 @@ local function setupBindings() end local mounted = false; -local throttleCD = false; -local function throttleCDDone() - throttleCD = false - -- update CD once more to confirm newest CD change is taken in even with some throttling - for _, button in pairs(activeButtons) do - updateCooldown(button, button.slot); - end -end local events = { ["ACTIONBAR_UPDATE_COOLDOWN"] = function() - if not throttleCD then -- only update at most once/frame - throttleCD = true; - for _, button in pairs(activeButtons) do - updateCooldown(button, button.slot); - end - CTimerAfter(0.01, throttleCDDone); -- wait one frame + for _, button in pairs(activeButtons) do + updateCooldown(button, button.slot); end end, ["SPELL_UPDATE_CHARGES"] = function() @@ -594,17 +627,13 @@ local events = { ["SPELL_ACTIVATION_OVERLAY_GLOW_SHOW"] = function(spell) -- TODO create mapping from spellIDs to buttons for _, button in pairs(activeButtons) do - updateGlow(button, button.slot, spell); - -- CD update might be throttled, force it - updateCooldown(button, button.slot); + startGlow(button, button.slot, spell); end end, ["SPELL_ACTIVATION_OVERLAY_GLOW_HIDE"] = function(spell) -- TODO create mapping from spellIDs to buttons for _, button in pairs(activeButtons) do - updateGlow(button, button.slot, spell, true); - -- CD update might be throttled, force it - updateCooldown(button, button.slot); + stopGlow(button, button.slot, spell); end end, ["UPDATE_BINDINGS"] = function() @@ -629,7 +658,7 @@ local events = { end end, ["PLAYER_LOGIN"] = function() - GameTooltip = _G["GameTooltip"]; -- TODO use PLAYER_ENTERING_WORLD with MoveAnything + GameTooltip = _G["GameTooltip"]; initialize(); end, ["ADDON_LOADED"] = function(addon) @@ -656,8 +685,6 @@ events["UNIT_ENTERED_VEHICLE"] = function(unit) if unit == "player" then events["ACTIONBAR_UPDATE_STATE"]() end end events["UNIT_EXITED_VEHICLE"] = events["UNIT_ENTERED_VEHICLE"]; --- TODO overlay glow ? don't exactly know what it does, proc highlight? --- tooltips ActionBars:RegisterEvent("ADDON_LOADED"); ActionBars:RegisterEvent("PLAYER_LOGIN");