X-Git-Url: https://www.aleksib.fi/git/wowui.git/blobdiff_plain/a7ed5dd91d9e3b5d58218dac0d60e593e776da0f..aa489f69ad687834efafeca19cbe4acb9fa68e57:/OmaUF/CastBar.lua?ds=sidebyside

diff --git a/OmaUF/CastBar.lua b/OmaUF/CastBar.lua
index f64cff2..8da7d22 100644
--- a/OmaUF/CastBar.lua
+++ b/OmaUF/CastBar.lua
@@ -15,9 +15,8 @@ local channelingColor = {0.32, 0.3, 1};
 local M = {};
 OmaUFCastBar = M;
 
--- TODO trade skill bar updates as well, check Quartz modules/Tradeskill.lua
 local function onUpdate(bar)
-    if not bar:IsShown() then return end -- TODO little fadeout possibly
+    if not bar:IsShown() then return end
     local width = bar.icon:IsShown() and bar.cast.width or bar.cast.width; -- TODO fullwidth
     local startTime, endTime = bar.startTime, bar.endTime;
     local currentClamped = min(GetTime(), endTime);
@@ -38,6 +37,16 @@ local function onUpdate(bar)
     bar.time:SetFormattedText("%.1f", remaining);
 end
 
+local function showBar(bar)
+    bar:Show();
+    bar:SetScript("OnUpdate", onUpdate);
+end
+
+local function hideBar(bar)
+    bar:Hide();
+    bar:SetScript("OnUpdate", nil);
+end
+
 local function toggleInterruptible(bar, nointr)
     if bar.unit == "player" then return end
     if nointr then
@@ -76,7 +85,7 @@ local function startCast(bar, unit, channeling)
     bar.spell:SetText(ssub(name, 1, bar.spell.count));
     bar.time:SetFormattedText("%.1f", (endTime - startTime)/1000);
     bar.cast:SetVertexColor(unpack(bar.cast.color));
-    bar:Show();
+    showBar(bar);
     toggleInterruptible(bar, noInterrupt);
     return true;
 end
@@ -88,7 +97,7 @@ local function applyDelay(bar, unit, channeling)
     else
         _, _, _, _, startTime, endTime = UnitCastingInfo(unit);
     end
-    if not startTime or not endTime then return bar:Hide() end
+    if not startTime or not endTime then return hideBar(bar) end
     bar.startTime = startTime / 1000;
     bar.endTime = endTime / 1000;
     -- TODO show delay text
@@ -99,7 +108,7 @@ local events = {
         startCast(bar, unit);
     end,
     ["PLAYER_TARGET_CHANGED"] = function(bar)
-        bar:Hide();
+        hideBar(bar);
         if not startCast(bar, bar.unit) then
             startCast(bar, bar.unit, true);
         end
@@ -107,8 +116,8 @@ local events = {
     ["UNIT_SPELLCAST_CHANNEL_START"] = function(bar, unit)
         startCast(bar, unit, true);
     end,
-    ["UNIT_SPELLCAST_STOP"] = function(bar, unit)
-        bar:Hide();
+    ["UNIT_SPELLCAST_STOP"] = function(bar)
+        hideBar(bar);
     end,
     ["UNIT_SPELLCAST_DELAYED"] = function(bar, unit)
         applyDelay(bar, unit);
@@ -127,7 +136,6 @@ events["UNIT_SPELLCAST_CHANNEL_STOP"] = events["UNIT_SPELLCAST_STOP"];
 
 local function onEvent(bar, event, unit)
     if unit == bar.unit or (bar.unit == "player" and unit == "vehicle") then
-        --print(unit, event)
         events[event](bar, unit);
     elseif event == "PLAYER_TARGET_CHANGED" then
         events[event](bar);
@@ -147,7 +155,6 @@ function M.RegisterCastEvents(bar)
     bar:RegisterEvent("UNIT_SPELLCAST_INTERRUPTIBLE");
     bar:RegisterEvent("UNIT_SPELLCAST_NOT_INTERRUPTIBLE");
     if bar.unit == "target" then bar:RegisterEvent("PLAYER_TARGET_CHANGED") end
-    bar:SetScript("OnUpdate", onUpdate);
     -- trigger initial check
     if not startCast(bar, bar.unit) then
         startCast(bar, bar.unit, true);
@@ -156,7 +163,7 @@ end
 
 function M.UnregisterCastEvents(bar)
     bar:UnregisterAllEvents();
-    bar:SetScript("OnUpdate", nil);
+    hideBar(bar);
 end
 
 function M.CreateCastBar(parent, unit, yoffset)